Quantcast

HTTP Server source code

classic Classic list List threaded Threaded
14 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

HTTP Server source code

Oren Hurvitz
Hi,

Where is the source code for the HTTP Server used by OpenSim? All I can find is the binary version, HttpServer_OpenSim.dll. I believe I found a bug in this library and I would like to fix it.

Oren
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: HTTP Server source code

Oren Hurvitz
Is it this one? - http://webserver.codeplex.com/

If so then it seems the version we're using in OpenSim is very old. The part that contains "my" bug has been completely rewritten. How about I try to update the library to the current version?
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: HTTP Server source code

Melanie-2
In reply to this post by Oren Hurvitz
It is in a separate SVN repository, opensim-libs.

Melanie

On 12/10/2011 09:08, Oren Hurvitz wrote:

> Hi,
>
> Where is the source code for the HTTP Server used by OpenSim? All I can find
> is the binary version, HttpServer_OpenSim.dll. I believe I found a bug in
> this library and I would like to fix it.
>
> Oren
>
> --
> View this message in context: http://opensim-dev.2196679.n2.nabble.com/HTTP-Server-source-code-tp6883843p6883843.html
> Sent from the opensim-dev mailing list archive at Nabble.com.
> _______________________________________________
> Opensim-dev mailing list
> [hidden email]
> https://lists.berlios.de/mailman/listinfo/opensim-dev
>
>
_______________________________________________
Opensim-dev mailing list
[hidden email]
https://lists.berlios.de/mailman/listinfo/opensim-dev
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: HTTP Server source code

Melanie-2
In reply to this post by Oren Hurvitz
We made specific changes to allow the event queue to work with the
viewer. We can't just use upstream.

Melanie

On 12/10/2011 09:12, Oren Hurvitz wrote:

> Is it this one? - http://webserver.codeplex.com/
>
> If so then it seems the version we're using in OpenSim is very old. The part
> that contains "my" bug has been completely rewritten. How about I try to
> update the library to the current version?
>
> --
> View this message in context: http://opensim-dev.2196679.n2.nabble.com/HTTP-Server-source-code-tp6883843p6883850.html
> Sent from the opensim-dev mailing list archive at Nabble.com.
> _______________________________________________
> Opensim-dev mailing list
> [hidden email]
> https://lists.berlios.de/mailman/listinfo/opensim-dev
>
>
_______________________________________________
Opensim-dev mailing list
[hidden email]
https://lists.berlios.de/mailman/listinfo/opensim-dev
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: HTTP Server source code

Nebadon Izumi
In reply to this post by Oren Hurvitz
http://opensimulator.org/svn/opensim-libs/HttpServer/

svn co http://opensimulator.org/svn/opensim-libs


On Wed, Oct 12, 2011 at 12:08 AM, Oren Hurvitz <[hidden email]> wrote:
Hi,

Where is the source code for the HTTP Server used by OpenSim? All I can find
is the binary version, HttpServer_OpenSim.dll. I believe I found a bug in
this library and I would like to fix it.

Oren

--
View this message in context: http://opensim-dev.2196679.n2.nabble.com/HTTP-Server-source-code-tp6883843p6883843.html
Sent from the opensim-dev mailing list archive at Nabble.com.
_______________________________________________
Opensim-dev mailing list
[hidden email]
https://lists.berlios.de/mailman/listinfo/opensim-dev



--
Michael Emory Cerquoni - Nebadon Izumi @ http://osgrid.org

_______________________________________________
Opensim-dev mailing list
[hidden email]
https://lists.berlios.de/mailman/listinfo/opensim-dev
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: HTTP Server source code

justincc
In reply to this post by Melanie-2
Yes this is very unfortunate - I think Crista knows more about the specific patches though I believe she will be very
busy at least for the next few weeks.

As you saw, the API/code structure of upstream has changed so it can't simply be dropped in.  But ideally, I think we
would port any patches and update OpenSim to use the newer HttpServer.  Or eventually use something that is better
maintained but I'm not sure there is anything good out there in CLR land.

On 12/10/11 08:13, Melanie wrote:

> We made specific changes to allow the event queue to work with the
> viewer. We can't just use upstream.
>
> Melanie
>
> On 12/10/2011 09:12, Oren Hurvitz wrote:
>> Is it this one? - http://webserver.codeplex.com/
>>
>> If so then it seems the version we're using in OpenSim is very old. The part
>> that contains "my" bug has been completely rewritten. How about I try to
>> update the library to the current version?
>>
>> --
>> View this message in context: http://opensim-dev.2196679.n2.nabble.com/HTTP-Server-source-code-tp6883843p6883850.html
>> Sent from the opensim-dev mailing list archive at Nabble.com.
>> _______________________________________________
>> Opensim-dev mailing list
>> [hidden email]
>> https://lists.berlios.de/mailman/listinfo/opensim-dev
>>
>>
> _______________________________________________
> Opensim-dev mailing list
> [hidden email]
> https://lists.berlios.de/mailman/listinfo/opensim-dev
>


--
Justin Clark-Casey (justincc)
http://justincc.org/blog
http://twitter.com/justincc
_______________________________________________
Opensim-dev mailing list
[hidden email]
https://lists.berlios.de/mailman/listinfo/opensim-dev
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: HTTP Server source code

Diva Canto
The HTTP server is one of those dark, ugly, scary corners of this
project. I'm not even sure I know all of its secrets. But here's what I
know. It started with  code that jhurliman and someone else had done. In
the process of using it, OpenSim devs found several bugs and submitted
patches to the upstream project, but the devs there were a bit too slow
integrating them (like they didn't act within the next day or
something...), so the OpenSim devs basically forked the project to the
point of no return. Within the past year I have also encountered bugs,
and I patched them in our fork.  But what's even worse is that the svn
repository where our fork lives has been showing signs of being
corrupted, so I haven't been able to push the changes there.

In other words, the latest version of that code is here on my machine!

This is *really* bad.

It's way up high on my priorities to move this to our git repo as soon
as I have time to code again -- which hopefully will happen in November.
But this move only takes us from hell to purgatory. It's a shame that we
forked the project and that we can't use the newest version of that
other project. So if anyone is brave enough to venture there, that would
be a major contribution...

On 10/12/2011 5:30 AM, Justin Clark-Casey wrote:

> Yes this is very unfortunate - I think Crista knows more about the
> specific patches though I believe she will be very busy at least for
> the next few weeks.
>
> As you saw, the API/code structure of upstream has changed so it can't
> simply be dropped in.  But ideally, I think we would port any patches
> and update OpenSim to use the newer HttpServer.  Or eventually use
> something that is better maintained but I'm not sure there is anything
> good out there in CLR land.
>
> On 12/10/11 08:13, Melanie wrote:
>> We made specific changes to allow the event queue to work with the
>> viewer. We can't just use upstream.
>>
>> Melanie
>>
>> On 12/10/2011 09:12, Oren Hurvitz wrote:
>>> Is it this one? - http://webserver.codeplex.com/
>>>
>>> If so then it seems the version we're using in OpenSim is very old.
>>> The part
>>> that contains "my" bug has been completely rewritten. How about I
>>> try to
>>> update the library to the current version?
>>>
>>> --
>>> View this message in context:
>>> http://opensim-dev.2196679.n2.nabble.com/HTTP-Server-source-code-tp6883843p6883850.html
>>> Sent from the opensim-dev mailing list archive at Nabble.com.
>>> _______________________________________________
>>> Opensim-dev mailing list
>>> [hidden email]
>>> https://lists.berlios.de/mailman/listinfo/opensim-dev
>>>
>>>
>> _______________________________________________
>> Opensim-dev mailing list
>> [hidden email]
>> https://lists.berlios.de/mailman/listinfo/opensim-dev
>>
>
>

_______________________________________________
Opensim-dev mailing list
[hidden email]
https://lists.berlios.de/mailman/listinfo/opensim-dev
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: HTTP Server source code

Oren Hurvitz
Hmm, what a sordid history this library has...

I checked out the latest version from Subversion (thanks Nebadon) and applied my fix. It seems to work fine. The change is very simple: there's a certain uncaught exception that causes OpenSim/Robust to terminate. I just added a catch-all statement.

This change should fix the following bugs:

http://opensimulator.org/mantis/view.php?id=5471
http://opensimulator.org/mantis/view.php?id=5694
http://opensimulator.org/mantis/view.php?id=5718

Diva, I was able to checkout from Subversion and compile without any problems. However, since you have changes on your machine that haven't been pushed to Subversion it means that the DLL that I created isn't up to date. Could you apply this patch to your local copy of HttpServer and push the new DLL to Git? Thanks!

Catch-all-exceptions.patch
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: HTTP Server source code

Oren Hurvitz
Alternatively, zip up the HttpServer directory and send it to me; I'll recompile and update the DLL myself. If someone could give me write access to this Subversion repository I can try to update it, too -- perhaps I'll have better luck in this, since I had no problems performing a checkout.
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: HTTP Server source code

Melanie-2
There is now a git repo and the subversion is read only.
_______________________________________________
Opensim-dev mailing list
[hidden email]
https://lists.berlios.de/mailman/listinfo/opensim-dev
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: HTTP Server source code

Diva Canto
I will try to take a look at this this weekend -- at least make sure
that my code is in sync with the new git version of this.

On 10/12/2011 9:45 AM, Melanie wrote:
> There is now a git repo and the subversion is read only.
> _______________________________________________
> Opensim-dev mailing list
> [hidden email]
> https://lists.berlios.de/mailman/listinfo/opensim-dev
>
>

_______________________________________________
Opensim-dev mailing list
[hidden email]
https://lists.berlios.de/mailman/listinfo/opensim-dev
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: HTTP Server source code

justincc
In reply to this post by Oren Hurvitz
That's great work, Oren.

You may also want to look at http://opensimulator.org/mantis/view.php?id=5571 which actually contains a patch for mono
that deals with a similar problem.  I don't pretend it's an optimal patch but it does work empirically.  I still haven't
got round to sending it up to Mono.  I suspect the problem you're dealing with isn't quite the same, though.

The new git repo Melanie mentioned can now be accessed anonymously as

git clone git://opensimulator.org/git/opensim-libs

Regarding DLLs, I think it's better if a current core developer builds it.  I know you wouldn't do anything suspect but
I think we need to be somewhat careful in this area.

On 12/10/11 17:18, Oren Hurvitz wrote:

> Hmm, what a sordid history this library has...
>
> I checked out the latest version from Subversion (thanks Nebadon) and
> applied my fix. It seems to work fine. The change is very simple: there's a
> certain uncaught exception that causes OpenSim/Robust to terminate. I just
> added a catch-all statement.
>
> This change should fix the following bugs:
>
> http://opensimulator.org/mantis/view.php?id=5471
> http://opensimulator.org/mantis/view.php?id=5694
> http://opensimulator.org/mantis/view.php?id=5718
>
> Diva, I was able to checkout from Subversion and compile without any
> problems. However, since you have changes on your machine that haven't been
> pushed to Subversion it means that the DLL that I created isn't up to date.
> Could you apply this patch to your local copy of HttpServer and push the new
> DLL to Git? Thanks!
>
> http://opensim-dev.2196679.n2.nabble.com/file/n6885669/Catch-all-exceptions.patch
> Catch-all-exceptions.patch
>
> --
> View this message in context: http://opensim-dev.2196679.n2.nabble.com/HTTP-Server-source-code-tp6883843p6885669.html
> Sent from the opensim-dev mailing list archive at Nabble.com.
> _______________________________________________
> Opensim-dev mailing list
> [hidden email]
> https://lists.berlios.de/mailman/listinfo/opensim-dev
>


--
Justin Clark-Casey (justincc)
http://justincc.org/blog
http://twitter.com/justincc
_______________________________________________
Opensim-dev mailing list
[hidden email]
https://lists.berlios.de/mailman/listinfo/opensim-dev
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: HTTP Server source code

Oren Hurvitz
Justin, I saw the Mono patch, but indeed it's for a different problem.
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: HTTP Server source code

Oren Hurvitz
Hi Diva,

Any updates on the source code for HttpServer? If you don't have time to add it to Subversion or Git then could you zip up whatever you have and post it here? I would like to update my copies of OpenSim in order to incorporate my bugfix (the one from the beginning of this thread), but I want to include all of your fixes as well.

Thanks,
Oren
Loading...