Policies for acceptance/rejection of patches

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Policies for acceptance/rejection of patches

Diva Canto
It has been suggested that the decisions for acceptance/rejection of
patches into OpenSimulator is arbitrary. That is not the case. The
decisions, however, aren't entirely mechanizable: some of the criteria
cannot be codified in something as simple as a code style checker.

The documentation for developers on the Wiki [1] has lots of good
information, but it was missing what I think is a very important piece:
compliance of the patches with the architectural principles of the
project. Here it is:

http://www.metaverseink.com/blog/opensim/policies-for-patching-opensimulator/

I hope this helps clarify things.

(I added this link to the Wiki, too)

[1] http://opensimulator.org/wiki/Developer_Documentation

_______________________________________________
Opensim-dev mailing list
[hidden email]
http://opensimulator.org/cgi-bin/mailman/listinfo/opensim-dev
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

The MOSES project will longer submit patches.

Maxwell, Douglas CIV USARMY RDECOM ARL (US)

The MOSES project is not suggesting, alluding, or hinting at anything.  I am stating for the record, based on our experiences with the code acceptance practices of the Open Simulator project, that the process is subjective.   

 

The MOSES project will longer submit patches.  This decision is based on the advice of one of the Open Simulator developers.  We will be working strictly from our public GitHub.  We will announce when code is ready for pulls.  You may do with it as you wish, and we will be available for consult should you want to modify it for inclusion in the Open Simulator codebase.  We are also writing a detailed "Open Sim PhysX API" document that you will find useful.  This decision allows for you to work at the pace you are accustomed to and it will not impact our schedule.

 

Although we are no longer submitting patches, if you work with us we can ensure the code that produced is in a state you would find immediately ingestible.

 

Good Luck.

 

Douglas Maxwell, Ph.D.
Science and Technology Manager
Virtual World Strategic Applications
U.S. Army Research Lab
Human Research & Engineering Directorate
Simulation & Training Technology Center
(c) <a tabindex="0" style="font: 13px/normal arial, sans-serif; color: rgb(17, 85, 204); text-transform: none; text-indent: 0px; letter-spacing: normal; word-spacing: 0px; white-space: normal; font-size-adjust: none; font-stretch: normal; background-color: rgb(255, 255, 255);" href="tel:%28407%29%20242-0209" target="_blank" value="&#43;14072420209">(407) 242-0209

From: [hidden email] [[hidden email]] on behalf of Diva Canto [[hidden email]]
Sent: Friday, August 21, 2015 5:59 PM
To: [hidden email]
Subject: [Opensim-dev] Policies for acceptance/rejection of patches

It has been suggested that the decisions for acceptance/rejection of
patches into OpenSimulator is arbitrary. That is not the case. The
decisions, however, aren't entirely mechanizable: some of the criteria
cannot be codified in something as simple as a code style checker.

The documentation for developers on the Wiki [1] has lots of good
information, but it was missing what I think is a very important piece:
compliance of the patches with the architectural principles of the
project. Here it is:

http://www.metaverseink.com/blog/opensim/policies-for-patching-opensimulator/

I hope this helps clarify things.

(I added this link to the Wiki, too)

[1] http://opensimulator.org/wiki/Developer_Documentation

_______________________________________________
Opensim-dev mailing list
[hidden email]
http://opensimulator.org/cgi-bin/mailman/listinfo/opensim-dev

_______________________________________________
Opensim-dev mailing list
[hidden email]
http://opensimulator.org/cgi-bin/mailman/listinfo/opensim-dev
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: The MOSES project will longer submit patches.

Dahlia Trimble
While I am somewhat disappointed by this decision I think it will probably be a good choice. We've pulled in other features from forks in the past and it's worked out fairly well although it's often is more work on our part. I'll still request that your developers join our IRC channel (irc.freenode.net #opensim-dev) and make use of this list while designing your physics implementation as we do have a fair bit of experience doing this sort of thing and may be able to help you as well as help ourselves later when we do pull your code.

On Sun, Aug 23, 2015 at 7:47 PM, Maxwell, Douglas CIV USARMY RDECOM (US) <[hidden email]> wrote:

The MOSES project is not suggesting, alluding, or hinting at anything.  I am stating for the record, based on our experiences with the code acceptance practices of the Open Simulator project, that the process is subjective.   

 

The MOSES project will longer submit patches.  This decision is based on the advice of one of the Open Simulator developers.  We will be working strictly from our public GitHub.  We will announce when code is ready for pulls.  You may do with it as you wish, and we will be available for consult should you want to modify it for inclusion in the Open Simulator codebase.  We are also writing a detailed "Open Sim PhysX API" document that you will find useful.  This decision allows for you to work at the pace you are accustomed to and it will not impact our schedule.

 

Although we are no longer submitting patches, if you work with us we can ensure the code that produced is in a state you would find immediately ingestible.

 

Good Luck.

 

Douglas Maxwell, Ph.D.
Science and Technology Manager
Virtual World Strategic Applications
U.S. Army Research Lab
Human Research & Engineering Directorate
Simulation & Training Technology Center
(c) <a style="font:13px/normal arial,sans-serif;color:rgb(17,85,204);text-transform:none;text-indent:0px;letter-spacing:normal;word-spacing:0px;white-space:normal;font-size-adjust:none;font-stretch:normal;background-color:rgb(255,255,255)" href="tel:%28407%29%20242-0209" value="+14072420209" target="_blank">(407) 242-0209

From: [hidden email] [[hidden email]] on behalf of Diva Canto [[hidden email]]
Sent: Friday, August 21, 2015 5:59 PM
To: [hidden email]
Subject: [Opensim-dev] Policies for acceptance/rejection of patches

It has been suggested that the decisions for acceptance/rejection of
patches into OpenSimulator is arbitrary. That is not the case. The
decisions, however, aren't entirely mechanizable: some of the criteria
cannot be codified in something as simple as a code style checker.

The documentation for developers on the Wiki [1] has lots of good
information, but it was missing what I think is a very important piece:
compliance of the patches with the architectural principles of the
project. Here it is:

http://www.metaverseink.com/blog/opensim/policies-for-patching-opensimulator/

I hope this helps clarify things.

(I added this link to the Wiki, too)

[1] http://opensimulator.org/wiki/Developer_Documentation

_______________________________________________
Opensim-dev mailing list
[hidden email]
http://opensimulator.org/cgi-bin/mailman/listinfo/opensim-dev

_______________________________________________
Opensim-dev mailing list
[hidden email]
http://opensimulator.org/cgi-bin/mailman/listinfo/opensim-dev



_______________________________________________
Opensim-dev mailing list
[hidden email]
http://opensimulator.org/cgi-bin/mailman/listinfo/opensim-dev
Loading...